The scaffold did not compile. src/lib.rs was written against an API that
does not exist at the pinned rev (f36931f):
- `impl Params` declared six methods that are not trait members
(`as_slice`, `param_by_id`, `param_by_name` and their `_mut` pairs) over
two types that appear nowhere in the crate (`AtomicParam`, `ParamId`).
The real trait is `unsafe trait Params` with one required method,
`param_map`, and is meant to be derived rather than hand-written.
- `type SysSysexMessage` misspells the associated type `SysExMessage`.
- `ChannelSamples` has no immutable `get`, so the passthrough loop's
`*frame.get_mut(ch).unwrap() = *frame.get(ch).unwrap()` could not resolve.
Replaced with `#[derive(Params)]` over an example gain parameter, so the
skeleton demonstrates the smoother and dB formatters a real plugin needs
instead of leaving an empty struct that teaches nothing. The passthrough
loop becomes an actual gain application for the same reason.
`editor()` is wired to a real `create_egui_editor` window in the same
change rather than a follow-up: nih_plug_egui was already a declared
dependency that nothing used, and the persisted `editor_state` field the
editor needs is part of the same params struct being rewritten here.
Splitting them would leave a commit whose params struct exists only to
serve an editor that is not there yet.
Verified against a local checkout of nih-plug at the pinned rev rather
than from memory, and confirmed by building.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WHt4DykxXaQnyaJfyS8KCn
mikkeli
irene