android-stuff/gps-speedo
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(02): revise plans based on checker feedback

Browse Source 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Mikkeli Matlock
2026-02-10 11:17:01 +09:00
parent 630cf1c578
commit 755c4b7b06
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.planning/phases/02-provider-migration/02-02-PLAN.md
+4 -1
View File
@@ -215,7 +215,8 @@ Run `flutter analyze` — no errors.
Verify main() is async with WidgetsFlutterBinding.ensureInitialized(). Verify main() is async with WidgetsFlutterBinding.ensureInitialized().
Verify MultiProvider wraps SpeedoApp with all 4 providers. Verify MultiProvider wraps SpeedoApp with all 4 providers.
Verify provider order: SharedPreferences first, then SettingsProvider, GpsDataManager, OverlayProvider. Verify provider order: SharedPreferences first, then SettingsProvider, GpsDataManager, OverlayProvider.
Verify ChangeNotifierProxyProvider2 passes dependencies to OverlayProvider.updateDependencies(). Verify ChangeNotifierProxyProvider2 passes dependencies to OverlayProvider.updateDependencies():
Grep for `ChangeNotifierProxyProvider2` in lib/main.dart and confirm it calls `updateDependencies`.
Verify overlayMain() is unchanged. Verify overlayMain() is unchanged.
Verify SpeedoApp no longer has isOverlayMode parameter. Verify SpeedoApp no longer has isOverlayMode parameter.
</verify> </verify>
@@ -230,6 +231,8 @@ main.dart wires MultiProvider with pre-initialized SharedPreferences, three Chan
<action> <action>
Full rewrite of SpeedometerScreen to consume providers via Consumer/Selector. This is the core of the "big bang migration." Full rewrite of SpeedometerScreen to consume providers via Consumer/Selector. This is the core of the "big bang migration."
**Trip tracking code removal:** Not needed — grep confirms no trip-related state, methods, or UI exist in the codebase. The context decision "remove trip tracking entirely" is satisfied by absence.
**State variables to REMOVE (now in providers):** **State variables to REMOVE (now in providers):**
- `_currentUnit` — now in SettingsProvider - `_currentUnit` — now in SettingsProvider
- `_currentThemeIndex` — now in SettingsProvider - `_currentThemeIndex` — now in SettingsProvider