From 755c4b7b0670b4bdab2122d8f2b323110c1869fc Mon Sep 17 00:00:00 2001 From: Mikkeli Matlock Date: Tue, 10 Feb 2026 11:17:01 +0900 Subject: [PATCH] fix(02): revise plans based on checker feedback Co-Authored-By: Claude Opus 4.6 --- .planning/phases/02-provider-migration/02-02-PLAN.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.planning/phases/02-provider-migration/02-02-PLAN.md b/.planning/phases/02-provider-migration/02-02-PLAN.md index 4db2b6d..ef53408 100644 --- a/.planning/phases/02-provider-migration/02-02-PLAN.md +++ b/.planning/phases/02-provider-migration/02-02-PLAN.md @@ -215,7 +215,8 @@ Run `flutter analyze` — no errors. Verify main() is async with WidgetsFlutterBinding.ensureInitialized(). Verify MultiProvider wraps SpeedoApp with all 4 providers. Verify provider order: SharedPreferences first, then SettingsProvider, GpsDataManager, OverlayProvider. -Verify ChangeNotifierProxyProvider2 passes dependencies to OverlayProvider.updateDependencies(). +Verify ChangeNotifierProxyProvider2 passes dependencies to OverlayProvider.updateDependencies(): + Grep for `ChangeNotifierProxyProvider2` in lib/main.dart and confirm it calls `updateDependencies`. Verify overlayMain() is unchanged. Verify SpeedoApp no longer has isOverlayMode parameter. @@ -230,6 +231,8 @@ main.dart wires MultiProvider with pre-initialized SharedPreferences, three Chan Full rewrite of SpeedometerScreen to consume providers via Consumer/Selector. This is the core of the "big bang migration." +**Trip tracking code removal:** Not needed — grep confirms no trip-related state, methods, or UI exist in the codebase. The context decision "remove trip tracking entirely" is satisfied by absence. + **State variables to REMOVE (now in providers):** - `_currentUnit` — now in SettingsProvider - `_currentThemeIndex` — now in SettingsProvider