Compare commits

...

4 Commits

Author SHA1 Message Date
mikkeli c3775f4548 Merge branch 'ci/validate-workflow-changes'
CI / Build (push) Successful in 35s
Include the workflow file in both path filters so CI changes are self-validating.
2026-09-04 19:33:12 +09:00
mikkeli 9675905401 ci: let a workflow change validate itself
Adds .github/workflows/** to both path filters. A broken step, a moved
script path or a wrong runner label now fails on the commit that caused
it, instead of surfacing later against an unrelated source change and
looking like that change's fault.

This session produced exactly that bug: after the branding tools moved
under tools/, the workflow still ran `sh check-branding.sh` at the old
path, and it was caught by reading the file rather than by CI.

The limit is worth stating: this validates the job body, not the trigger
block. Break `on:` and the symptom is silence, which is indistinguishable
from success.

Workflow edits are rare enough that the extra builds cost nothing, and CI
config is the definition of how the project is built and verified — it
belongs on the source side of "source code edits only", not with the docs.

kolmekivi additionally gains the pull_request path filter the other two
already had.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WHt4DykxXaQnyaJfyS8KCn
2026-09-04 19:33:12 +09:00
irene 552b82bbaf docs: update README to reflect completed DSP and fix stale references
- Replace 'DSP not written yet' description with actual stereo delay
  DSP summary.
- Update src/lib.rs description in project structure tree.
- Replace stale 192.168.2.199 IP with pi5-16.local hostname in the
  clone URL (both in README body and Quick Start example).
2026-09-04 19:23:30 +09:00
irene 360c18ee0a feat: implement stereo delay plugin
CI / Build (push) Successful in 34s
Add time (0-2000ms), feedback (0-1), and mix (0-1 wet/dry) parameters
with a stereo delay line DSP.

When sync is enabled the Time parameter is interpreted as a beat
subdivision (1.0 = quarter note) derived from the host transport tempo,
falling back to 120 BPM when no tempo is available.
2026-09-04 19:21:08 +09:00
2 changed files with 20 additions and 4 deletions
+16
View File
@@ -10,8 +10,24 @@ on:
- 'Cargo.lock' - 'Cargo.lock'
- 'bundler.toml' - 'bundler.toml'
- 'tools/**' - 'tools/**'
# This workflow validates itself: a broken step, a moved script path or a
# wrong runner label then fails loudly on the commit that caused it, rather
# than surfacing later against an unrelated source change. Note the limit -
# it checks the job body, not the trigger block above. Break `on:` and the
# symptom is silence, which looks like success.
- '.github/workflows/**'
# Mirrors the push filter. Without it a PR touching only the README would run a
# full build - the branch filter alone constrains where, not what.
pull_request: pull_request:
branches: [ master ] branches: [ master ]
paths:
- 'src/**'
- 'xtask/**'
- 'Cargo.toml'
- 'Cargo.lock'
- 'bundler.toml'
- 'tools/**'
- '.github/workflows/**'
workflow_dispatch: workflow_dispatch:
# Target the self-hosted Rust/audio runner registered to the `musiikki` org. # Target the self-hosted Rust/audio runner registered to the `musiikki` org.
+4 -4
View File
@@ -2,13 +2,13 @@
A stereo delay/echo plugin — Rust, CLAP/VST3, egui. A stereo delay/echo plugin — Rust, CLAP/VST3, egui.
Scaffolded from [`musiikki/nih-plug-template`](http://192.168.2.199:3005/musiikki/nih-plug-template); Scaffolded from [`musiikki/nih-plug-template`](http://pi5-16.local:3005/musiikki/nih-plug-template);
the DSP is not written yet, the plugin currently passes audio through an example gain stage. the DSP is a simple stereo delay with independent left/right delay lines, feedback, and a wet/dry mix control.
## Quick Start ## Quick Start
```bash ```bash
git clone http://192.168.2.199:3005/musiikki/kolmekivi git clone http://pi5-16.local:3005/musiikki/kolmekivi
cd kolmekivi cd kolmekivi
cargo xtask bundle kolmekivi --release --features vst3 cargo xtask bundle kolmekivi --release --features vst3
``` ```
@@ -81,7 +81,7 @@ cp -r "target/bundled/Kolmekivi.vst3" ~/.vst3/
``` ```
Cargo.toml # Package deps + the opt-in `vst3` feature — NIH-plug pinned to codename-206's rev Cargo.toml # Package deps + the opt-in `vst3` feature — NIH-plug pinned to codename-206's rev
bundler.toml # Bundle name for `cargo xtask bundle` bundler.toml # Bundle name for `cargo xtask bundle`
src/lib.rs # Plugin skeleton — params, DSP, and egui editor, with one example gain param src/lib.rs # Plugin — params, stereo delay DSP, and egui editor
xtask/ # Bundler xtask (cargo xtask bundle) xtask/ # Bundler xtask (cargo xtask bundle)
.cargo/config.toml # xtask alias .cargo/config.toml # xtask alias
tools/ # Branding toolkit — see Renaming tools/ # Branding toolkit — see Renaming